-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REditorSupport.R] No update after change of publishId #591
Comments
@filiptronicek Is there something to be done in this repository, e.g. migrate the extension to the new publishId? @renkun-ken This seems to be the right time to verify the extension in the Open VSX Registry. |
@filiptronicek @renkun-ken Please get in touch with each other regarding REditorSupport/vscode-R#524 to ensure a smooth transition. Thank you. |
I'd like to hear what should be done on my side? |
Hi there @benz0li, thanks for bringing this to our attention. @renkun-ken I will remove the old version ( It seems that there is already a publishing GitHub Action workflow that publishes to the VS Code Marketplace and so you should be fine with just adding a repo secret with the Open VSX access token and then replace the publish:
name: Publish
timeout-minutes: 30
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: node $SCRIPT_DIR/enableWebpack.js
- run: yarn install
- name: Publish to Open VSX Registry
uses: HaaLeo/publish-vscode-extension@v1
id: publishToOpenVSX
with:
pat: ${{ secrets.OPEN_VSX_TOKEN }}
- name: Publish to Visual Studio Marketplace
uses: HaaLeo/publish-vscode-extension@v1
with:
pat: ${{ secrets.VSCE_TOKEN }}
registryUrl: https://marketplace.visualstudio.com
extensionFile: ${{ steps.publishToOpenVSX.outputs.vsixPath }}
|
I tried manually publishing the v2.5.0 via
but the following error always occurs:
|
I tried with my macOS machine and a Windows azure server. Both result in the same error. Any ideas? |
@filiptronicek Could @renkun-ken have missed something from https://github.com/eclipse/openvsx/wiki/Publishing-Extensions? |
This should not be happening because of any client error, so I contacted the team to look into this. |
@filiptronicek Any news from the team? |
I've created a ticket on the helpdesk, since the team member I contacted was not available: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330. cc @benz0li |
@filiptronicek No reaction at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330 so far. Please ping the Help Desk once again. |
@filiptronicek It is now a month since you opened the ticket at Eclipse Help Desk. Still no reaction... Could you try to get someone to take care of your ticket? Thank you. |
Sorry for not mentioning it here, @benz0li, but I have reached out to Eclipse again, I really hope they can take a look now, I will keep in touch with them and post updates here. |
@renkun-ken @phillc73 The owner of namespace |
@eclipsewebmaster Could someone please take care of https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330? Thank you. FYI @mbarbero |
@renkun-ken Can you try again? Just recently, Open VSX was unstable and rolled back to an older, working state. Maybe something has changed... |
For the record, rust-analyzer also has platform-specific VSIXes. We've added OpenVSX publishing to CI a while ago, but it never worked, not even while EclipseFdn/open-vsx.org#1094 was merged. See the history on https://github.com/rust-lang/rust-analyzer/actions/workflows/release.yaml. If anyone on the OpenVSX side wants to look into it (we might very well be using |
I tried again and still the same... |
I have now written an email to the Eclipse Foundation. In many projects, communication has suffered somewhat in the time of (and after) COVID-19. |
@filiptronicek They are now waiting for your answer at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330. |
Responded, thanks @benz0li for making me aware of the update, interestingly enough, I did not get an email notification about this 🤔. |
@filiptronicek ping Another extension facing the same problem. @MWEclipse It would be great to have some more context on the log excerpt you posted. Thank you. |
@renkun-ken @filiptronicek Any news on this issue? |
@MWEclipse I kindly ask you to give your insight on https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1027645? |
@MWEclipse ping Would you be so kind to share your insight on https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1027645? Thank you. |
@renkun-ken Can you try again?
– https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1033611 |
@renkun-ken Please update ovsx before trying. |
Just tried with the latest
|
@renkun-ken FYI #634 (comment) Why no explicit error message? Most likely it is
|
Or maybe it is just not possible to use the same extension name in two different namespaces.
vs
|
That should be possible. https://open-vsx.org/api/REditorSupport:
|
I assume it is the very same problem for the following extensions:
@renkun-ken @lnicola @badsyntax Is my assumption correct? Please confirm or deny. It works for |
@benz0li you're right, I don't think it's the name per se. https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330#note_1033949 fails on a duplicate GUID, which seems to belong to |
Here we go: https://open-vsx.org/extension/rust-lang/rust-analyzer |
@renkun-ken @badsyntax Same procedure for |
Sorry for all the cross-posting, but I wanted to get to the bottom of this – without creating yet another account. Thank you @amvanbaren and @MWEclipse for all your support and insight. Keep up the great work @EclipseFdn! Thank you @filiptronicek. |
@renkun-ken It would be great, if you could re-release older versions of the R extension under the new namespace ( |
@benz0li can you clarify exactly what you want me to confirm or deny? |
The extension is already published at https://open-vsx.org/extension/richardwillis/vscode-gradle. Confirm or deny whether you want to publish at https://open-vsx.org/extension/vscjava/vscode-gradle or not. (Has the extension been migrated at the VS Code marketplace at some point?) |
@benz0li The extension was transferred to Microsoft and republished in a different namespace in the marketplace. I no longer own the project and thus won't be able to publish to open-vsx under the new namespace. Not sure what to do in this scenario. Best I can do is try remove the old extension from open-vsx. Any suggestions? |
IMHO Removing all published versions of Surprisingly, it is already part of https://github.com/open-vsx/publish-extensions/blob/master/extensions.json... but never seemed to have been published. Ping @amvanbaren and @MWEclipse. (Removal will most likely be done by @kineticsquid) |
Everything relevant has now been recorded here. As soon as the R extension is released under the new namespace, I will close it. |
Not sure if I'm understanding it correctly. I just need to remove all previous releases of It seems that I cannot remove Also, if I download the old extension vsix files from GitHub releases, some of these files were packaged under old namespace. I guess I should only publish the versions from https://marketplace.visualstudio.com/items?itemName=REditorSupport.r&ssr=false#version-history. |
Yes, since there does not seem to be a way to migrate to another namespace. Removal will most likely be done by @kineticsquid on request.
Yes, please.
That would be OK with me. I can not speak for others, though. |
@kineticsquid, please remove Once they are removed, I'll publish since v2.5.0. |
@renkun-ken Please ask for removal at https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1330, too. The staff from Eclipse Foundation is not that responsive here [on GitHub]. |
Done 👌 |
I am happy to finally close this issue. Big thank you @ren-kun and @kineticsquid
Update: Now for both |
- Install from Open VSX Registry again - EclipseFdn/publish-extensions#591
See REditorSupport/vscode-R#690 (comment) ff
The text was updated successfully, but these errors were encountered: