Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/evaluate no grad #201

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Fix/evaluate no grad #201

merged 5 commits into from
Feb 5, 2024

Conversation

belerico
Copy link
Member

@belerico belerico commented Feb 5, 2024

Summary

This PR fixes a problem related to the increasing memory consuption for dreamer-v3 during the evaluation phase. In particular it let the user choose whether to disable gradients during the evaluation phase with the config parameter disable_grads, i.e. one can launch an evaluation with:

python sheeprl_eval.py checkpoint_path=/path/to/checkpoint.ckpt disable_grads=True

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 062b21b into main Feb 5, 2024
10 checks passed
@belerico belerico deleted the fix/evaluate-no-grad branch February 11, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants