Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/delete old ckpts #171

Merged
merged 124 commits into from
Dec 19, 2023
Merged

Feature/delete old ckpts #171

merged 124 commits into from
Dec 19, 2023

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Added the possibility to automatically delete the oldest checkpoints by specifying the number of checkpoints you want to keep (checkpoint.keep_last parameter). If this parameter is set to None, then no checkpoints are automatically deleted.

Type of Change

Please select the one relevant option below:

  • New feature (non-breaking change that adds functionality)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

belerico and others added 30 commits October 5, 2023 22:01
@belerico
Add first PPO numpy buffer implementation
7135dcb
@belerico
Merge branch 'main' of https://github.com/Eclectic-Sheep/sheeprl into…
055cacd 
… feature/buffer-np
@belerico
Add distribution cfg to agent
91dbdcb
@belerico
No need for tensordict
8174704
@belerico
Add SAC numpy
9da5a86
@belerico
Improve sample_next_obs
3cc29cf
@belerico
Add DV1 with numpy buffer
1882b6a
@belerico
Too much reshapes
024cc98
@belerico
Add Sequential and EnvIndipendent np buffers
4e4389e
@belerico
Fewer number of reshapes
c5fc229
@belerico
Faster indexing + from_numpy parameter
34b3261
@belerico
Dreamer-V2 numpy
f549019
@belerico
Fix buffer add
5131e60
@belerico
Better indexing
ded1b19
@belerico
Fix indexes to sample
f513171
@belerico
Fix metrics when they are nan
48d20d3
@belerico
Fix reshape when bootstrapping + fix normalization
82b576a
@belerico
Guard timer metrics
f029e1e
@belerico
Merge branch 'fix/algos' of github.com:Eclectic-Sheep/sheeprl into fe…
6b423f5 
…ature/buffer-np
@belerico
np.intp for indexing
f12ecb1
@belerico
Change dtype after creating the tensor
f8546f4
@belerico
Merge branch 'main' of https://github.com/Eclectic-Sheep/sheeprl into…
662e54c 
… feature/buffer-np
@belerico
Merge branch 'main' of github.com:Eclectic-Sheep/sheeprl into feature…
fb7b7c8 
…/buffer-np
@belerico
Fix buf[key] after __getstate__ is called upon checkpoint
b79d67d
@belerico
Securely close fd on __getstate__()
1260c06
@belerico
Add MemmapArray
2b7ef10
@belerico
Merge branch 'feature/buffer-np' of https://github.com/Eclectic-Sheep…
385405d 
…/sheeprl into feature/buffer-np
@belerico
Add __len__ function
75f0664
@belerico
Fix len
63ec5e6
@belerico
Merge branch 'feature/buffer-np' of github.com:Eclectic-Sheep/sheeprl…
a9b323c 
… into feature/buffer-np
belerico and others added 19 commits December 15, 2023 12:44
@belerico
Merge branch 'feature/buffer-np' of https://github.com/Eclectic-Sheep…
706d728 
…/sheeprl into feature/buffer-np
@michele-milesi
feat: from tensordict to buffers np
dc6c9ce
@belerico
from td to np
39974e0
@belerico
Merge branch 'feature/buffer-np' of https://github.com/Eclectic-Sheep…
495661c 
…/sheeprl into feature/buffer-np
@belerico
exclude mlflow from tests
2150065
@belerico
No more tensordict
21412af
@belerico
Updated howto
818b490
@belerico
Fix tests
a82e5a2
@belerico
.cpu().numpy() just one time
a0f108a
@belerico
Removed old cfgs
f2c5e38
@belerico
Convert all when hydra instantiating
a8766df
@belerico
convert all on instantiate
2ad65f3
@belerico
[skip-ci] Removed pokemon files
ad10fe2
@michele-milesi
fix: git merge related errors
ba04da0
@belerico
Fix get absolute path
63b1f7e
@belerico
Merge branch 'feature/buffer-np' of https://github.com/Eclectic-Sheep…
ab3ee64 
…/sheeprl into feature/buffer-np
@belerico
Amend dreamer-v3 pokemon config
fb0c7d0
@michele-milesi
feat: added keep_last parameter
2fed15f
@michele-milesi
merge: main into feature/delete-old-ckpts
1f0bac3
@michele-milesi michele-milesi linked an issue Dec 19, 2023 that may be closed by this pull request
Automatic deletion of oldest checkpoints #170
Closed
@belerico belerico merged commit 46e35cc into main Dec 19, 2023
9 checks passed
@michele-milesi michele-milesi deleted the feature/delete-old-ckpts branch December 19, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideTr8 DavideTr8 DavideTr8 approved these changes

@belerico belerico belerico approved these changes

@rcmalli rcmalli Awaiting requested review from rcmalli rcmalli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic deletion of oldest checkpoints
3 participants
@michele-milesi @belerico @DavideTr8