-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/buffer np #169
Merged
Merged
Feature/buffer np #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belerico
requested review from
DavideTr8,
michele-milesi and
rcmalli
as code owners
December 18, 2023 15:41
michele-milesi
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we have introduced our new buffers, that handle data with standard dictionaries of numpy arrays instead of TensorDicts. This change has been introduced to keep algorithms implementation and interaction as simple as possible, while also gaining in terms of speed performance. In particular:
sheeprl.utils.memmap.MemmapArray
, which is a simple container to work with numpy memory-mapped arrays. Those arrays can be easily shared between processes that share the same underlying file-system and once shared they maintain the ownership of the array being sharedEpisodeBuffer
api has been made compliant to theReplayBuffer
api:add
method takes in input one or more steps (possibly containing multiple episodes) instead of a single episodeCheckpointCallback
has been adapted to our new buffersType of Change
Please select the one relevant option below:
Checklist
Please confirm that the following tasks have been completed:
Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.