Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optional mlflow #164

Merged
merged 12 commits into from
Dec 1, 2023
Merged

Feature/optional mlflow #164

merged 12 commits into from
Dec 1, 2023

Conversation

belerico
Copy link
Member

@belerico belerico commented Dec 1, 2023

Summary

This PR let MLFlow be an optional dependency. In particular:

  • Every agent defines its own log_models method
  • Everything related to MLFlow has been moved to sheeprl/utils/mlflow.py
  • Added optional MLFlow tests, which can be run with python tests/run_tests_mlflow.py

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 9729e9f into main Dec 1, 2023
9 checks passed
@belerico belerico deleted the feature/optional-mlflow branch December 21, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants