Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/minedojo #148

Merged
merged 12 commits into from
Nov 9, 2023
Merged

Fix/minedojo #148

merged 12 commits into from
Nov 9, 2023

Conversation

michele-milesi
Copy link
Member

Summary

Describe the purpose of the pull request, including:

  • Fix minedojo wrapper: removed / from the name of the observations to a correct creation of the memmap files when memmap buffer is used.
  • Moved exploratory action from Player to MinedojoActor for dreamer-based algorithms. In this way, the player is general and can be used with all the environments. Instead, for using an environment that needs to mask actions, the user has to define a custom actor (as the MinedojoActor).
  • In Dreamer-like algorithms, now, the Actor defines the add_exploration_noise method that takes in input the actions and adds to them some noise.
  • In Dreamer-like algorithms, the exploration configs now must be defined under the algo.actor key, not under the algo.player one.

Type of Change

Please select the one relevant option below:

  • Bug fix (non-breaking change that solves an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Please confirm that the following tasks have been completed:

  • I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
  • I have added unit tests for my changes, or updated existing tests if necessary.
  • I have updated the documentation, if applicable.
  • I have installed pre-commit and run locally for my code changes.

Screenshots or Visuals (Optional)

If applicable, please provide screenshots, diagrams, graphs, or videos of the changes, features or the error.

Additional Information (Optional)

Please provide any additional information that may be useful for the reviewer, such as:

  • Any potential risks or challenges associated with the changes.
  • Any instructions for testing or running the code.
  • Any other relevant information.

Thank you for your contribution! Once you have filled out this template, please ensure that you have assigned the appropriate reviewers and that all tests have passed.

@belerico belerico merged commit 7971d61 into main Nov 9, 2023
@michele-milesi michele-milesi deleted the fix/minedojo branch November 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants