Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete TDD-based unit tests #3

Merged
merged 3 commits into from
Oct 28, 2014
Merged

Conversation

Echelon9
Copy link
Owner

Fixes Issue #1 by ensuring the BloomFilter.Size() probabilistic-based test clears.

  • Is it mergable?
  • Did it pass the tests on Windows, Excel 2003?
  • Did it pass the tests on Windows, Excel 2007?
  • Was a spellchecker run on the source code and documentation after changes were made?

@Echelon9
Copy link
Owner Author

Confirmed unit tests worked on Excel 2003 (11.8347.8341) SP3.
The testing also successfully utilised the latest version of Excel-TDD provided by @timhall

InlineRunner.RunSuite Specs, ShowFailureDetails:=True, ShowPassed:=True, ShowSuiteDetails:=True

= PASS (6 of 6 passed) = 28/10/2014 8:23:53 PM =========================
+ BloomFilter
  + basic bloom filter
  + jabberwocky
  + basic uint32
  + wtf
  + works with integer types
  + size
===

Echelon9 added a commit that referenced this pull request Oct 28, 2014
@Echelon9 Echelon9 merged commit 93e1a2e into master Oct 28, 2014
@Echelon9 Echelon9 mentioned this pull request Oct 28, 2014
3 tasks
@Echelon9 Echelon9 deleted the fix/size-probabilistic-unit-test branch October 28, 2014 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant