Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX fatal error on loading pictures in attached documents of an event #1015

Closed
wants to merge 1 commit into from
Closed

FIX fatal error on loading pictures in attached documents of an event #1015

wants to merge 1 commit into from

Conversation

lvessiller-opendsi
Copy link

FIX fatal error on loading pictures in attached documents of an event
DLB : Dolibarr#30553

  • a fatal error occurs when the source file of the picture is loading
  • the variable "langs" is not set and you got the fatal error : "Call to a member function trans() on null"
  • so the picture is not loaded

Before

  • attach a picture on an event and you won't see the preview of it :
    image

After

  • you see again the preview of the picture :
    image

I removed the comment lines and the unused local variable "transcode"

@lvessiller-opendsi lvessiller-opendsi mentioned this pull request Aug 5, 2024
Merged
@lvessiller-opendsi
Copy link
Author

Merged on 18.0

@lvessiller-opendsi
Copy link
Author

Already merged on v18

@lvessiller-opendsi lvessiller-opendsi deleted the 2024_rc_fix-action-document-load-attached-pictures branch August 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lvessiller-opendsi