Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add travis tests #14

Closed
wants to merge 5 commits into from
Closed

Add travis tests #14

wants to merge 5 commits into from

Conversation

javiereguiluz
Copy link
Contributor

PHP Cs Fixer is failing with this error:

[LogicException]                                                               
  You must call one of in() or append() methods before iterating over a Finder.

I don't understand why. It works locally for me. 😕

xabbuh
xabbuh reviewed May 26, 2017
View reviewed changes
.travis.yml Outdated

cache:
directories:
- $HOME/.composer/cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be $HOME/.composer/cache/files to not cache Composer metadata

xabbuh
xabbuh reviewed May 26, 2017
View reviewed changes
.travis.yml Outdated

install:
- if [[ "$CHECK_PHP_SYNTAX" == "yes" ]]; then composer require --dev --no-update friendsofphp/php-cs-fixer; fi;
- composer update --prefer-dist --no-interaction --no-suggest --no-progress --ansi $COMPOSER_FLAGS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you never define $COMPOSER_FLAGS

ferrastas
ferrastas reviewed Jun 2, 2017
View reviewed changes
.travis.yml

script:
- vendor/bin/phpunit
- if [[ "$CHECK_PHP_SYNTAX" == "yes" ]]; then php vendor/bin/php-cs-fixer --no-interaction --dry-run --diff -v fix; fi;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a dot after fix.

- if [[ "$CHECK_PHP_SYNTAX" == "yes" ]]; then php vendor/bin/php-cs-fixer --no-interaction --dry-run --diff -v fix .; fi;

@javiereguiluz javiereguiluz mentioned this pull request Mar 31, 2018
Closed
javiereguiluz added a commit that referenced this pull request Mar 31, 2018
@javiereguiluz
minor #50 Updated PHP-CS and Travis config (javiereguiluz)
343d977 
This PR was squashed before being merged into the 1.0.x-dev branch (closes #50).

Discussion
----------

 Updated PHP-CS and Travis config

This fixes #14.

Commits
-------

2854984  Updated PHP-CS and Travis config
@javiereguiluz javiereguiluz deleted the add_travis_tests branch March 31, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@ferrastas ferrastas ferrastas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @ferrastas @xabbuh