Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow older symfony/deprecation-contracts #4939

Closed
wants to merge 1 commit into from

Conversation

quentint
Copy link
Contributor

@quentint quentint commented Jan 3, 2022

Note: I opened a similar PR on doctrine/mongodb-odm: doctrine/mongodb-odm#2403

Trying to install doctrine/mongodb-odm-bundle is not possible because of a symfony/deprecation-contracts conflict. This PR fixes that.

@javiereguiluz javiereguiluz added this to the 4.x milestone Jan 3, 2022
@javiereguiluz
Copy link
Collaborator

Quentin, thanks a lot for this proposal. I see that the Doctrine bundle has merged your PR to allow using contracts ^3.0 with it. So, please let me close this PR without merging because we'd prefer to have the constraints of our "master" branch as updated as possible. If we found other conflicts with other bundles, we can reopen this and merge it. Thanks!

@quentint
Copy link
Contributor Author

quentint commented Jan 3, 2022

Absolutely, yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants