Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twemoji: Replace Deprecated MaxCDN with JDecked Twemoji #126

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Twemoji: Replace Deprecated MaxCDN with JDecked Twemoji #126

merged 3 commits into from
Sep 5, 2024

Conversation

sr229
Copy link
Contributor

@sr229 sr229 commented Sep 4, 2024

twitter/twemoji#580 states the usual cdn (MaxCDN) is no longer working, this replaces it to use cdnjs instead on the latest version (14.0.2).

twitter/twemoji#580 states the usual cdn (MaxCDN) is no longer working, this replaces it to use cdnjs instead on the latest version (14.0.2).
@Cynosphere
Copy link
Contributor

Might as well switch over to https://github.com/jdecked/twemoji as well so its 1:1 with Discord's Twemoji, since you locked it to version 14 anyways and jdecked's pseudofork supports emoji version 15.

@Earu
Copy link
Owner

Earu commented Sep 4, 2024

Not merging jsdeliver, I've already tested this cdn before and it breaks widly for some people. Very very unreliable.

Co-authored-by: Cynthia Foxwell <gamers@riseup.net>
@sr229 sr229 changed the title Twemoji: Replace Deprecated MaxCDN with CDNJS Twemoji: Replace Deprecated MaxCDN with JDecked Twemoji Sep 5, 2024
@sr229
Copy link
Contributor Author

sr229 commented Sep 5, 2024

I could also use https://cdnjs.cloudflare.com/ajax/libs/twemoji/15.1.0/72x72/ but IIRC Russian users will suffer because Cloudflare is throttled in their end or https://cdn.statically.io/gh/jdecked/twemoji/main/assets/72x72/ however I haven't tested if this is consistent geographically. Will keep @Cynosphere's changes for now.

(PS: for those interested try browsing the statically version or the cdnjs version to see if this is fast/stable for you)

@sr229 sr229 requested a review from Cynosphere September 5, 2024 15:31
@Earu Earu merged commit 184be44 into Earu:master Sep 5, 2024
@sr229 sr229 deleted the twemoji-cdnjs branch September 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants