Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to lts-15.8 #5

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Upgrade to lts-15.8 #5

merged 1 commit into from
Apr 17, 2020

Conversation

rossabaker
Copy link
Contributor

  • Need to add some MonadFail constraints for ghc-8.8, and an orphan to use it.
  • Can't derive ParseTime instances in time-1.9. We get around this by specializing a couple helpers.

Copy link

@jasonpunzalan jasonpunzalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😷

Copy link

@andreyk0 andreyk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Interesting, I guess that's fine, it's a Date anyway.

@rossabaker
Copy link
Contributor Author

For posterity, the ParseTime issue. I created one relying on the internals, but even then, one of the two failed the property tests. If we ever really need it, we should look at the time-1.10 upgrade. But I don't anticipate that's a battle we'll ever need to fight.

@rossabaker rossabaker merged commit fd9028c into master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants