Adding powermeter interface to DcSupplySimulator #758
Conversation
Signed-off-by: Sebastian Lukas <sebastian.lukas@pionix.de>
10668fc to
c277302
Compare
| energy_import_total += (connector_voltage * connector_current * 0.5) / 3600; | ||
| } | ||
| if (connector_current < 0) { | ||
| energy_export_total += (connector_voltage * -connector_current * 0.5) / 3600; |
There was a problem hiding this comment.
This 0.5 directly correlates with LOOP_SLEEP_MS. Perhaps you should use that constant (i.e. LOOP_SLEEP_MS / 1000.0) instead.
There was a problem hiding this comment.
Good point 👍 I'll change that quickly
| types::powermeter::TransactionStartResponse | ||
| powermeterImpl::handle_start_transaction(types::powermeter::TransactionReq& value) { | ||
| return {types::powermeter::TransactionRequestStatus::OK}; | ||
| } | ||
|
|
||
| types::powermeter::TransactionStopResponse powermeterImpl::handle_stop_transaction(std::string& transaction_id) { | ||
| return {types::powermeter::TransactionRequestStatus::NOT_SUPPORTED, | ||
| {}, | ||
| {}, | ||
| "DcSupplySimulator does not support stop transaction request."}; | ||
| } |
There was a problem hiding this comment.
It's a bit peculiar that this module would "successfully" handle StartTransaction, but not StopTransaction. I have not found this combination anywhere else.
This is about OCMF. right? So types::powermeter::TransactionRequestStatus::NOT_SUPPORTED in both cases, IMHO.
There was a problem hiding this comment.
I took this directly from the JsDcSupplySimulator module. But it makes sense that the StartTransaction is not supported here either. I will change that too.
|
Oops, too late, already merged. 😁 |
Describe your changes
see title
Issue ticket number and link
Missing powermeter interface in DcSupplySimulator
Checklist before requesting a review