GenericPowermeter: improve logging and fix Modbus range #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Modbus RTU address range only permits addresses from 1 to 247 (at least what makes sense in our context here). Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
4 tasks
This introduces a high-level/device specific logging in case communication with power meter is failing or communication is restored again. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
c186c80 to
c1246a6
Compare
hikinggrass
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR fixes a small issue with the allowed range of Modbus addresses, and it introduces log messages in case the power meter communication is interrupted or restored.
Issue ticket number and link
The logging part is related to #523, but it not the complete fix for this issue.
Checklist before requesting a review