Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uMWC: adapt driver to new firmware #723

Merged
merged 3 commits into from
Jun 25, 2024
Merged

uMWC: adapt driver to new firmware #723

merged 3 commits into from
Jun 25, 2024

Conversation

corneliusclaussen
Copy link
Contributor

@corneliusclaussen corneliusclaussen commented Jun 13, 2024 •
edited
Loading

Describe your changes

Adapt uMWC driver to latest firmware

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@corneliusclaussen corneliusclaussen force-pushed the bugfix/umwc-new-firmware branch from c626939 to 6f90f56 Compare June 13, 2024 09:23
@corneliusclaussen corneliusclaussen marked this pull request as draft June 13, 2024 09:42
@corneliusclaussen corneliusclaussen force-pushed the bugfix/remove-exits branch 2 times, most recently from 4f93cc3 to dc37686 Compare June 13, 2024 09:52
@corneliusclaussen corneliusclaussen force-pushed the bugfix/umwc-new-firmware branch from 6f90f56 to 860f9f8 Compare June 13, 2024 09:53
Base automatically changed from bugfix/remove-exits to main June 21, 2024 07:32
@corneliusclaussen corneliusclaussen marked this pull request as ready for review June 21, 2024 12:51
@corneliusclaussen corneliusclaussen force-pushed the bugfix/umwc-new-firmware branch from 860f9f8 to 1707c03 Compare June 24, 2024 09:58
SebaLukas
SebaLukas approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

modules/MicroMegaWattBSP/board_support/evse_board_supportImpl.cpp Outdated Show resolved Hide resolved
modules/MicroMegaWattBSP/MicroMegaWattBSP.cpp Show resolved Hide resolved
modules/MicroMegaWattBSP/MicroMegaWattBSP.cpp Show resolved Hide resolved
@corneliusclaussen corneliusclaussen force-pushed the bugfix/umwc-new-firmware branch from 8d7f3d6 to 1135abc Compare June 24, 2024 15:57
@Pietfried Pietfried added the include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible label Jun 25, 2024
@corneliusclaussen
uMWC: adapt driver to new firmware
bd4ca50 
Signed-off-by: Cornelius Claussen <cc@pionix.de>
@corneliusclaussen
Review comments
d1f8c99 
Signed-off-by: Cornelius Claussen <cc@pionix.de>
@corneliusclaussen
Powermeter proper start/stop reply
df695a5 
Signed-off-by: Cornelius Claussen <cc@pionix.de>
@corneliusclaussen corneliusclaussen force-pushed the bugfix/umwc-new-firmware branch from f962761 to df695a5 Compare June 25, 2024 13:22
@corneliusclaussen corneliusclaussen merged commit 54848fd into main Jun 25, 2024
6 of 8 checks passed
@corneliusclaussen corneliusclaussen deleted the bugfix/umwc-new-firmware branch June 25, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebaLukas SebaLukas SebaLukas approved these changes

@hikinggrass hikinggrass hikinggrass approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@a-w50 a-w50 Awaiting requested review from a-w50

Assignees

@hikinggrass hikinggrass

Labels
include-in-release Tag that this PR should be included in the current merge window for the upcoming release if possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corneliusclaussen @hikinggrass @SebaLukas @Pietfried