Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect sentinel value in YetiDriver #709

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix incorrect sentinel value in YetiDriver #709

merged 1 commit into from
Jun 6, 2024

Conversation

matteocarnelos
Copy link
Contributor

Describe your changes

The sentinel value used in wait_for_caps() to determine if the for loop reaches the end without breaking before is incorrect. The for loop exits when i reaches 50, not 49.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@corneliusclaussen corneliusclaussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@corneliusclaussen
Copy link
Contributor

@matteocarnelos Could you please sign-off your commit? Otherwise we cannot merge, this is a LF requirement

Signed-off-by: Matteo Carnelos <matteo.carnelos98@gmail.com>
@matteocarnelos
Copy link
Contributor Author

@corneliusclaussen Done!

@corneliusclaussen corneliusclaussen merged commit b22d74a into EVerest:main Jun 6, 2024
6 checks passed
@matteocarnelos matteocarnelos deleted the fix/incorrect-sentinel-value branch June 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants