-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel: read dependencies.yaml on the fly #699
Merged
hikinggrass
merged 6 commits into
EVerest:main
from
Qwello:move_bazel_dep_parsing_to_edm
Jun 25, 2024
Merged
Bazel: read dependencies.yaml on the fly #699
hikinggrass
merged 6 commits into
EVerest:main
from
Qwello:move_bazel_dep_parsing_to_edm
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golovasteek
force-pushed
the
move_bazel_dep_parsing_to_edm
branch
from
May 26, 2024 06:40
e5758d2
to
beb74d0
Compare
golovasteek
changed the title
Move bazel dep parsing to edm
Bazel: read dependencies.yaml on the fly
May 26, 2024
golovasteek
force-pushed
the
move_bazel_dep_parsing_to_edm
branch
2 times, most recently
from
May 26, 2024 06:58
78a2fb0
to
5791506
Compare
1 task
golovasteek
requested review from
Pietfried,
hikinggrass,
corneliusclaussen,
SebaLukas,
a-w50,
SirVer and
dorezyuk
as code owners
May 26, 2024 07:57
dorezyuk
approved these changes
May 27, 2024
SirVer
approved these changes
Jun 4, 2024
hikinggrass
reviewed
Jun 10, 2024
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
golovasteek
force-pushed
the
move_bazel_dep_parsing_to_edm
branch
from
June 25, 2024 13:18
5791506
to
614c260
Compare
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
golovasteek
force-pushed
the
move_bazel_dep_parsing_to_edm
branch
from
June 25, 2024 13:30
e4c82a8
to
a1d79d3
Compare
hikinggrass
approved these changes
Jun 25, 2024
corneliusclaussen
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Before this PR, for every change in the dependencies.yaml we had to to run
bazel run //:update
to re-generate bazel files, which was an annoying extra step.This change moves the code that generates bazel dependencies into
edm
tool, and bazel leverages it to generate dependencies on the fly.So there is again just one file with all the dependencies.
Issue ticket number and link
Checklist before requesting a review
edm
and update dependencies in the gitlab action.