Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: read dependencies.yaml on the fly #699

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

golovasteek
Copy link
Contributor

@golovasteek golovasteek commented May 26, 2024

Describe your changes

Before this PR, for every change in the dependencies.yaml we had to to run bazel run //:update to re-generate bazel files, which was an annoying extra step.

This change moves the code that generates bazel dependencies into edm tool, and bazel leverages it to generate dependencies on the fly.

So there is again just one file with all the dependencies.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements
  • release edm and update dependencies in the gitlab action.

@golovasteek golovasteek force-pushed the move_bazel_dep_parsing_to_edm branch from e5758d2 to beb74d0 Compare May 26, 2024 06:40
@golovasteek golovasteek changed the title Move bazel dep parsing to edm Bazel: read dependencies.yaml on the fly May 26, 2024
@golovasteek golovasteek force-pushed the move_bazel_dep_parsing_to_edm branch 2 times, most recently from 78a2fb0 to 5791506 Compare May 26, 2024 06:58
@golovasteek golovasteek marked this pull request as ready for review May 26, 2024 07:57
@Pietfried Pietfried assigned Pietfried and hikinggrass and unassigned Pietfried May 28, 2024
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
@golovasteek golovasteek force-pushed the move_bazel_dep_parsing_to_edm branch from 5791506 to 614c260 Compare June 25, 2024 13:18
Signed-off-by: Evgeny Petrov <evgeny@epetrov.net>
@golovasteek golovasteek force-pushed the move_bazel_dep_parsing_to_edm branch from e4c82a8 to a1d79d3 Compare June 25, 2024 13:30
@hikinggrass hikinggrass merged commit 65b8e2c into EVerest:main Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants