Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/UI hanzla #6

Merged
merged 9 commits into from
Dec 6, 2024
Merged

Feature/UI hanzla #6

merged 9 commits into from
Dec 6, 2024

Conversation

hanzla-khalid1
Copy link
Collaborator

home page design

Copy link
Collaborator

@usama-tariq1 usama-tariq1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review requested changes and ask questions if any

src/app/(home)/page.tsx Outdated Show resolved Hide resolved
src/app/(home)/page.tsx Outdated Show resolved Hide resolved
src/app/(home)/page.tsx Outdated Show resolved Hide resolved
src/app/(home)/page.tsx Outdated Show resolved Hide resolved
src/components/HomeLayoutComponents/footer.tsx Outdated Show resolved Hide resolved
src/components/mentorcard.tsx Outdated Show resolved Hide resolved
src/components/mentorcard.tsx Outdated Show resolved Hide resolved
src/components/mentorcard.tsx Outdated Show resolved Hide resolved
src/components/sessioncard.tsx Outdated Show resolved Hide resolved
src/components/ui/sidebar.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@usama-tariq1 usama-tariq1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review requested changes

src/app/(home)/home.css Outdated Show resolved Hide resolved
src/app/(home)/home.css Outdated Show resolved Hide resolved
src/app/(home)/layout.tsx Outdated Show resolved Hide resolved
src/app/(home)/page.tsx Outdated Show resolved Hide resolved
src/app/globals.css Show resolved Hide resolved
src/components/SkillTag/SkillTag.css Outdated Show resolved Hide resolved
src/components/SkillTag/SkillTag.css Outdated Show resolved Hide resolved
src/components/SkillTag/SkillTag.tsx Outdated Show resolved Hide resolved
src/components/SkillTag/SkillTag.tsx Outdated Show resolved Hide resolved
src/components/ui/calendar.tsx Outdated Show resolved Hide resolved
const PublicLayout = ({ children }: { children: ReactNode }) => {
return (
<>
<Header />
{children}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a content wrapper class around children


const NavbarItems = () => {
return (
<div className='navbar'>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this a separate component and use it inside footer as well

@usama-tariq1 usama-tariq1 merged commit bf4a90c into development Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants