Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASIM-5600] Read History Matching results #364

Conversation

ro-oliveira95
Copy link
Contributor

@ro-oliveira95 ro-oliveira95 commented Mar 1, 2024

Add History Matching metadata and reading functions to aggregator to allow reading HM results data.

ASIM-5600

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #364 (697764a) into fb-ASIM-5256-history-matching-results-management (8ea02b8) will decrease coverage by 0.02%.
Report is 1 commits behind head on fb-ASIM-5256-history-matching-results-management.
The diff coverage is 99.37%.

Additional details and impacted files
@@                                 Coverage Diff                                  @@
##           fb-ASIM-5256-history-matching-results-management     #364      +/-   ##
====================================================================================
- Coverage                                             99.97%   99.95%   -0.02%     
====================================================================================
  Files                                                    55       55              
  Lines                                                  6811     6951     +140     
====================================================================================
+ Hits                                                   6809     6948     +139     
- Misses                                                    2        3       +1     

@ro-oliveira95 ro-oliveira95 force-pushed the fb-ASIM-5600-read-history-matching-results branch from 23c07ef to def0ef4 Compare March 4, 2024 21:32
@ro-oliveira95 ro-oliveira95 changed the title Add History Matching metadata and reading functions to aggregator Read History Matching results Mar 4, 2024
@ro-oliveira95 ro-oliveira95 changed the title Read History Matching results [ASIM-5600] Read History Matching results Mar 4, 2024
@ro-oliveira95 ro-oliveira95 marked this pull request as ready for review March 4, 2024 21:48
@ro-oliveira95 ro-oliveira95 force-pushed the fb-ASIM-5600-read-history-matching-results branch from def0ef4 to 697764a Compare March 5, 2024 18:54
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ro-oliveira95 ro-oliveira95 merged commit f9402a1 into fb-ASIM-5256-history-matching-results-management Mar 12, 2024
11 of 17 checks passed
@ro-oliveira95 ro-oliveira95 deleted the fb-ASIM-5600-read-history-matching-results branch March 12, 2024 18:58
@ro-oliveira95
Copy link
Contributor Author

Ops, I accidentally merged this PR without addressing the review appointments.
Will address then in the base branch's PR #369.

@nicoddemus
Copy link
Member

Will address then in the base branch's PR #369.

Not sure that's what you meant, but please create a new PR targeting #369.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants