Add invoke tasks to a collection #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 99.96% 99.97%
=======================================
Files 55 55
Lines 6652 6675 +23
=======================================
+ Hits 6650 6673 +23
Misses 2 2 |
b0f0163 to
253a566
Compare
ThalesCarl
commented
Jan 26, 2024
nicoddemus
approved these changes
Jan 26, 2024
prusse-martin
approved these changes
Jan 26, 2024
eniohayashi
approved these changes
Jan 29, 2024
ggrbill
approved these changes
Jan 29, 2024
37f23e2 to
15b94f9
Compare
Previously, the invoke tasks were defined in the global namespace. Now we add them to a collection in order to facilitate the overloading of tasks by the user plugins and to better organize them. ASIM-5375
15b94f9 to
78063d9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the invoke tasks were defined in the global namespace. This PR aims to add them to a collection in order to facilitate the overloading of tasks by the user plugins and to better organize them.
Off-topic: I've also included in this PR a check if the
updatefunction successfully created thehook_specs.hfile.ASIM-5375