Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] create (empty) linkings.yml file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haianos
Copy link

@haianos haianos commented Mar 28, 2018

This solve an issue when running esrocos_build_project.
In fact, esrocos_build_project fails if no linkings.yml is found in the project's root folder.

This solve an issue when running `esrocos_build_project`
@Kynneb Kynneb self-assigned this Mar 28, 2018
@Kynneb
Copy link
Collaborator

Kynneb commented Mar 28, 2018

This error which is fixed by this PR was introduced a while back, when in the CMakeLists.txt template the

esrocos_install_dependency_info()

has been commented out by default. This macro will create the (empty) linkings.yml on calling of amake. However I am intrigued if your proposal wouldn't be even smoother because it would make the (maybe counter-intuitive) use of this macro obsolete.

The error is adressed on master and stable branch of the buildconf right now, but I will play with this a bit the next week.

@haianos
Copy link
Author

haianos commented Mar 28, 2018

If you are fine with having always the linkings.yml file in the project folder, I would suggest my solution simply because it is there where you generate the esrocos.yml as well.
All esrocos_XXX_XXX commands (that you can apply on an existing project) do not work without esrocos.yml (to my understanding!). Currently, this is true also for linkings.yml once you call esrocos_build_project (or calling the generated build-script.sh manually).

Instead, if you have a good reason to do not have the linkings.yml in some edge-cases, then I would keep the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants