Refactor the functions in derive_evspsblpot due to new iris #2023
Conversation
|
@ESMValGroup/tech-reviewers this PR is ready for review. Who has time for it? Thank you. |
There was a problem hiding this comment.
Hey Sarah, nice digging and I guess the workaround is fine for now. However, I think this doesn't improve the overall clarity of the code (ideally the equations can be mapped on to one to those in the paper), so we should consider reverting this once the bug is properly solved in Iris.
I'm surprised that codacy doesn't complain about the import order. Can you verify with isort?
| import numpy as np | ||
| import iris |
There was a problem hiding this comment.
Doesn't isort want it the other way around?
There was a problem hiding this comment.
Thank you. Running prospector on this file didn't complain about it, pylint says: third party import "import numpy as np" should be placed before "import iris"pylint.
|
@ESMValGroup/esmvaltool-coreteam this PR is ready for a merge. Thank you. |
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the PR is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
🛠 YAML files passpre-commitoryamllintchecks🛠 Documentation builds successfully on readthedocsNew or updated recipe/diagnostic:
🛠 Provenance information has been added🛠 New dependencies are added to the [project requirements](https://docs.esmvaltool.org/en/latest/community/diagnostic.html#additional-dependencies)@esmvalbotor some other machine without modification### New or updated data reformatting script:To help with the number pull requests: