-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lazy_regrid.py for wflow diagnostics #2025
Comments
Comparing the performance of wflow_recipe regarding refactoring lazy_regrid script before (wflow_master) and after (wflow_pr):
the differences in one of the outputs wflow_ERA-Interim_Meuse_1990_2001.nc the resource_usage.txt |
@SarahAlidoost Thanks for the nice report! What are your conclusions from this? |
Ah, sorry, didn't see the conclusions, but they are there already. It's a bit worrying that there is a difference at all in the runtime and memory use. Do you think the runtimes could vary per run? |
Nice comparison @SarahAlidoost ! Half an hour more on 1-1.5 hours in total is quite a big difference I'd say. I'd like to know how this is possible, but that might be out of scope for your current objective, or not? |
with new commits, the performance is improved. Now the differences in the variable pet is zero too (see below). It seems that the runtime varies per run. Now, it took less than one hour (see new resource_usage.txt). the differences in one of the outputs wflow_ERA-Interim_Meuse_1990_2001.nc |
please see my comment here. |
OK, that's good news, because the implementation I did in iris is almost identical to what was here in ESMValTool, I would expect it to be only slightly more efficient. Therefore it would have been strange if there were big differences in runtime. Maybe the difference in runtime/memory use is because not all the nodes have the same hardware (assuming you're running on Cartesius: https://userinfo.surfsara.nl/systems/cartesius/usage/batch-usage#heading7) or because of other users also accessing the shared file system. |
The recipe wflow.yml returns memory error if it uses e.g. 10 years of data. The diagnostics wflow.py uses regrid function with scheme area_weighted. The memory error is explained in an open issue in SciTools/iris/issues/3808 .
With the new version of iris, the lazy_regrid script benefits from a refactoring. Note that the regrid preprocessor cannot be moved to the recipe because the format of wflow target grid file is
.map
.The text was updated successfully, but these errors were encountered: