Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch back to Python 3.12 for conda lock file creation due to mamba<2 pin #2606

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Dec 3, 2024

Description

mamba<2 is not compatible with Python 3.13, and we are pinning it until conda-lock==3 comes about, so I am switching the pin in the conda lock generator workflow, back to Python 3.12, so we can have updated conda lock files in the meantime. See https://github.com/ESMValGroup/ESMValCore/actions/runs/12102229199/job/33856299466


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi changed the title switch back to Python 3.12 for conda lock file creation due to mamba<2 switch back to Python 3.12 for conda lock file creation due to mamba<2 pin Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (0f9e888) to head (60ad1fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2606   +/-   ##
=======================================
  Coverage   94.74%   94.74%           
=======================================
  Files         252      252           
  Lines       14506    14506           
=======================================
  Hits        13744    13744           
  Misses        762      762           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi
Copy link
Contributor Author

whoa two approves - I feel flattened, gents 😁

@valeriupredoi valeriupredoi merged commit 5353ab0 into main Dec 10, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the keep_python312_condalock branch December 10, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants