Improve the exception message when an option within the rootpath section is missing from the user configuration file #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2236 +/- ##
=======================================
Coverage 93.47% 93.48%
=======================================
Files 238 238
Lines 12927 12927
=======================================
+ Hits 12084 12085 +1
+ Misses 843 842 -1
|
ehogan
commented
Oct 19, 2023
Comment on lines
+411
to
+412
| raise KeyError(f'The "{project}" option is missing from the "rootpath" ' | ||
| 'section in the config-user.yml file.') |
There was a problem hiding this comment.
The pre-commit hooks made all the changes in this PR, except for this one, which is the one I made :)
valeriupredoi
approved these changes
Oct 20, 2023
| with mock.patch.dict(local.CFG, cfg): | ||
| msg = rf"The \"{project}\" option is missing.*" | ||
| with pytest.raises(KeyError, match=msg): | ||
| local._get_rootpath(project) |
There was a problem hiding this comment.
well, you made these changes too, unless precommit hooks now write unit tests too (which would be fab) 😁
There was a problem hiding this comment.
🤣 🤣 🤣 I added these after I made that comment! 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2235
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: