Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blesses for non-bfb testing suite #4746

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Conversation

mkstratos
Copy link
Collaborator

When blessing the non-bfb suite, not all history files were archived.
This generates an incomplete baseline, as these test depend on ensembles.

Test suite: e3sm_nbfb

@mkstratos mkstratos requested a review from jgfouca February 6, 2025 19:16
@jgfouca
Copy link
Contributor

jgfouca commented Feb 6, 2025

Looks like this may have broken unit tests. If you can fix it quickly, I'll add this to the CIME update I'm doing for E3SM.

@mkstratos
Copy link
Collaborator Author

This update fixes the unit tests (apart from the conda error on 3.8). I didn't fully understand how the unit tests passed the values, but I think this puts parameters in the right place now.

@jgfouca jgfouca merged commit cebccac into master Feb 10, 2025
7 checks passed
@jgfouca jgfouca deleted the mkstratos/bless-nbfb-tests branch February 10, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants