Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chmod command in safe_copy #3364

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

billsacks
Copy link
Member

Test suite: manual testing only (see below); did NOT run
scripts_regression_tests, since it seems this line must not be covered
by automated testing (otherwise tests would have failed)
Test baseline: n/a
Test namelist changes: none
Test status: bit for bit

Manual testing:

I created a temporary refdir:

[/glade/p/cesmdata/cseg/inputdata/cesm2_init/bill.test]
$ ls 0501-01-01/
b.e21.B1850.f09_g17.CMIP6-piControl.001.clm2.r.0501-01-01-00000.nc  rpointer.lnd

Then did the following:

./create_newcase --case $scratch/test_refcase_baseline_0123a --res f09_g17 --compset X --run-unsupported
./xmlchange RUN_TYPE=hybrid,RUN_REFCASE=bill.test,RUN_REFDIR=cesm2_init,RUN_REFDATE=0501-01-01
./xmlchange GET_REFCASE=TRUE
./case.setup
./case.build
^C
# Changed rpointer.lnd file in the refdir
./case.build
# Verified that the run directory has the new rpointer.lnd

I first verified that the second case.build command failed from the
baseline code (i.e., that I could properly reproduce the problem). With
the new code, the safe_copy no longer fails and the new rpointer.lnd
file is copied as desired.

Fixes #3363

User interface changes?: N

Update gh-pages html (Y/N)?: N

Code review:

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@billsacks
Copy link
Member Author

@fischer-ncar if possible it would be good to get this fix into CESM2.1.2.

@jgfouca FYI. I didn't bother assigning you as a reviewer since the fix seems trivial enough, but feel free to look at this if you want.

@jgfouca
Copy link
Contributor

jgfouca commented Jan 23, 2020

Thanks for finding and fixing this. I apologize for introducing this bug... not sure how it got through testing.

@fischer-ncar
Copy link
Contributor

I'll get this into cesm2.1.2.

@fischer-ncar fischer-ncar merged commit 3688f02 into ESMCI:maint-5.6 Jan 23, 2020
@billsacks billsacks deleted the fix_safe_copy branch January 23, 2020 22:22
jgfouca pushed a commit that referenced this pull request Mar 16, 2020
Remove machine-specific flags and avoid FP exceptions on invalid FP values with GNU.

Addresses #1832

[BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CRITICAL maint-5.6_bugfix should be merged to both maint-5.6 and master tp: CIMElib ty: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants