Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit OMP_NUM_THREADS in MPI-only runs #3085

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Omit OMP_NUM_THREADS in MPI-only runs #3085

merged 2 commits into from
Jun 5, 2019

Conversation

amametjanov
Copy link
Member

Omit OMP_NUM_THREADS in MPI-only runs

Test suite: SMS.f19_g16.X
Test baseline: mpi-only vs. threaded
Test namelist changes: none
Test status: [bit for bit]

Fixes #3082

User interface changes?: none

Update gh-pages html (Y/N)?: N

jedwards4b
jedwards4b approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jedwards4b
Copy link
Contributor

@jgfouca any reason not to merge this one?

@jgfouca jgfouca merged commit 89fad14 into master Jun 5, 2019
@jgfouca
Copy link
Contributor

jgfouca commented Jun 5, 2019

Didn't realize this was waiting on me, sry.

@jgfouca jgfouca deleted the azamat/threading/dont-set-threads-for-mpi-only-runs branch June 5, 2019 19:08
@jgfouca
Copy link
Contributor

jgfouca commented Jun 10, 2019

@amametjanov , we're going to have to revert this PR. Both CESM and E3SM have many machines where the mpirun command is configured to use OMP_NUM_THREADS from the environment. If it's not set, then CIME will crash.

@amametjanov
Copy link
Member Author

Okay

jgfouca added a commit that referenced this pull request Jun 11, 2019
@jgfouca
Revert "Merge pull request #3085 from ESMCI/azamat/threading/dont-set…
1878414 
…-threads-for-mpi-only-runs"

This reverts commit 89fad14, reversing
changes made to 5c43a15.
rfiorella pushed a commit to rfiorella/cime that referenced this pull request Jun 13, 2024
@jgfouca @rfiorella
Revert "Merge pull request ESMCI#3085 from ESMCI/azamat/threading/don…
5c7cffa 
…t-set-threads-for-mpi-only-runs"

This reverts commit 89fad14, reversing
changes made to 5c43a15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedwards4b jedwards4b jedwards4b approved these changes

@jgfouca jgfouca jgfouca approved these changes

Assignees

@jgfouca jgfouca

Labels
in progress Low Priority ty: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't set OMP_NUM_THREADS in MPI-only runs
4 participants
@amametjanov @jedwards4b @jgfouca @rljacob