minor bug fixes for xml interface #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
approved these changes
Apr 2, 2019
fischer-ncar
added a commit
that referenced
this pull request
Apr 4, 2019
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
fischer-ncar
added a commit
that referenced
this pull request
Apr 4, 2019
This PR undoes a merge from master to maint-5.6 that was done by accident. Then cherry-picked PR #3057 and #3053 back into maint-5.6. Commands that were used. git reset --hard 398df65 git cherry-pick -m 1 30f288c 4e37fe6 Test suite: Compared file differences for the two PRs and 398df65. Then xxdiff files for this PR with older maint-5.6 before the master merge. Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
fischer-ncar
added a commit
that referenced
this pull request
Apr 4, 2019
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
fischer-ncar
added a commit
that referenced
this pull request
Apr 4, 2019
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
fischer-ncar
added a commit
that referenced
this pull request
Apr 4, 2019
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
fischer-ncar
added a commit
that referenced
this pull request
Apr 4, 2019
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
fischer-ncar
added a commit
that referenced
this pull request
Apr 5, 2019
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes [CIME Github issue #] User interface changes?: Update gh-pages html (Y/N)?: Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in debug code to_string and valid_value list - if valid_value is present but empty this should return an empty list. An empty list in valid_value means that any value is allowed.
Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes [CIME Github issue #]
User interface changes?:
Update gh-pages html (Y/N)?:
Code review: