Allow CHARGE_ACCOUNT to use subprojects and default to command line given project #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 29, 2018 12:02
While the documentation says the CHARGE_ACCOUNT falls back to PROJECT if it cannot be found in the user environment, user config, or machine config, it actually only fell back to the probed machine value and not the value set at the command line which should override the probed value. Now, CHARGE_ACCOUNT will actually fall back to the previously determined correct PROJECT value. Fixes #2676
This makes the help message for `--project` uniform for the three `create_*` scripts, and updates the CIME user config doccumentation to better describe PROJECT and CHARGE_ACCOUNT
|
@billsacks I updated a little of the documentation; what do you think of those updates? |
jedwards4b
approved these changes
Oct 29, 2018
|
(i.e., you need a separate "Fixes" for each issue.) (My comment isn't enough to auto-close those: you'll need to edit your initial comment.) |
|
@billsacks Woops! You're right. Fixed my fixes. |
billsacks
approved these changes
Oct 29, 2018
jhkennedy
pushed a commit
to E3SM-Project/E3SM
that referenced
this pull request
Oct 30, 2018
jhkennedy
pushed a commit
to E3SM-Project/E3SM
that referenced
this pull request
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHARGE_ACCOUNT was not falling back to the project value given on the command line in #2676 and was fixed in #2763 . However, #2763 no longer allowed for subprojects to be charged on OLCF machines. This reverts #2763 and fixes both #2676 and #2886.
Test suite: scripts_regression_tests.py on Titan
Test baseline: N/A
Test namelist changes: N/A
Test status: [bit for bit]
Fixes #2676
Fixes #2886
User interface changes?: None
Update gh-pages html (Y/N)?: Y
Code review: