Transition CIME to using a custom util for copying files. #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filecopy operation is very common in CIME and we were using a smattering of shutil.copyfile, shutil.copy, and shutil.copy2. All these were replaced by safe_copy, a flexble and fault-tolerant copying function. This should make it much easier for users to share case directories and other common directories.
|
@jedwards4b , bump |
jedwards4b
approved these changes
Apr 17, 2018
|
Nice cleanup - thanks. |
jgfouca
pushed a commit
that referenced
this pull request
Aug 8, 2018
First of occasional merges of maint-1.0 to master. Make sure all bug fixes/additions made to maint-1.0 are also on master. * maint-1.0: Fix a typo in LICENSE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file-copy operation is very common in CIME and we were using
a smattering of shutil.copyfile, shutil.copy, and shutil.copy2.
This PR replaces these with safe_copy, a flexble and fault-tolerant
copying function. This should make it much easier for users to share
case directories and other common directories.
Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes [CIME Github issue #]
User interface changes?: N
Update gh-pages html (Y/N)?: n
Code review: @jedwards4b