Allow running infnan unit tests even in DEBUG mode #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, we have been skipping the shr_infnan unit tests when
building in DEBUG mode. Since we pretty much always build the unit tests
in DEBUG mode, that means that we're pretty much never running the
shr_infnan unit tests.
In trying (and failing) to solve #1763, I came up with a way to get the
shr_infnan unit tests to run and pass even when building in debug
mode. That is implemented here.
Test suite: ./scripts_regression_tests.py N_TestUnitTest on cheyenne
Also, cime fortran unit tests on my mac (with gnu)
Test baseline: N/A
Test namelist changes: none
Test status: bit for bit
Fixes #1809
User interface changes?: no
Update gh-pages html (Y/N)?: N
Code review: