Fix pylint errors #1490
Merged
Fix pylint errors #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
requested changes
May 8, 2017
There was a problem hiding this comment.
I opened issue #1488 because I would prefer not to have a mix of format and %s in the code. I would like all of the code to use %s for now and format in version 5.4. So can we remove the logging-format-interpolation flag along with the use of format?
|
@jedwards4b This PR will get us back to a passing state in the nightlies, the question of string format can be decided later. The ignored waring is useless in either case. |
jedwards4b
approved these changes
May 8, 2017
jgfouca
added a commit
that referenced
this pull request
Jun 2, 2017
Update to cime5.3-alpha10 Pulling in another 2 weeks of CIME changes into ACME. CIME hash 15297cd from May 2. Required bug fixes for: Changing error to warning for using "-id" with single dash acme templates missing "arg =" Restore pio1 Cmake path pointing to pio2/cmake Update to gcc5.3.0 to avoid internal compiler error Still had 2 fails of acme_developer on penn machine, but look to be weird gcc issues -- var tracking overflow. Same tests passed on redsky, so expecting it will pass on ACME machines. [BFB] * agsalin/update-to-cime5.3.1: (219 commits) Add fix to bug in docn that was in this cime version Fix upstream merge resolution mistake Bug fix: Handle failures to get mem usage from baselines Make single-dash before multichar arg a warning Fix acme template change for new parser Update Sandia worksations to gcc5.3.0 Comment out invalid_args check Revert change in pio1 to point into pio2/cmake Fix single submit Add tests Do not override walltime unless test Update ChangeLog nag compiler needs a width Add checks to verify the create_newcase directory was created as expected removed unpack commented region fix typo in parse_args Bug fixes Minor pylint fix fix pylint issues rename function ...
jgfouca
added a commit
that referenced
this pull request
Feb 23, 2018
Update to cime5.3-alpha10 Pulling in another 2 weeks of CIME changes into ACME. CIME hash 15297cd from May 2. Required bug fixes for: Changing error to warning for using "-id" with single dash acme templates missing "arg =" Restore pio1 Cmake path pointing to pio2/cmake Update to gcc5.3.0 to avoid internal compiler error Still had 2 fails of acme_developer on penn machine, but look to be weird gcc issues -- var tracking overflow. Same tests passed on redsky, so expecting it will pass on ACME machines. [BFB] * agsalin/update-to-cime5.3.1: (219 commits) Add fix to bug in docn that was in this cime version Fix upstream merge resolution mistake Bug fix: Handle failures to get mem usage from baselines Make single-dash before multichar arg a warning Fix acme template change for new parser Update Sandia worksations to gcc5.3.0 Comment out invalid_args check Revert change in pio1 to point into pio2/cmake Fix single submit Add tests Do not override walltime unless test Update ChangeLog nag compiler needs a width Add checks to verify the create_newcase directory was created as expected removed unpack commented region fix typo in parse_args Bug fixes Minor pylint fix fix pylint issues rename function ...
jgfouca
added a commit
that referenced
this pull request
Mar 13, 2018
Update to cime5.3-alpha10 Pulling in another 2 weeks of CIME changes into ACME. CIME hash 15297cd from May 2. Required bug fixes for: Changing error to warning for using "-id" with single dash acme templates missing "arg =" Restore pio1 Cmake path pointing to pio2/cmake Update to gcc5.3.0 to avoid internal compiler error Still had 2 fails of acme_developer on penn machine, but look to be weird gcc issues -- var tracking overflow. Same tests passed on redsky, so expecting it will pass on ACME machines. [BFB] * agsalin/update-to-cime5.3.1: (219 commits) Add fix to bug in docn that was in this cime version Fix upstream merge resolution mistake Bug fix: Handle failures to get mem usage from baselines Make single-dash before multichar arg a warning Fix acme template change for new parser Update Sandia worksations to gcc5.3.0 Comment out invalid_args check Revert change in pio1 to point into pio2/cmake Fix single submit Add tests Do not override walltime unless test Update ChangeLog nag compiler needs a width Add checks to verify the create_newcase directory was created as expected removed unpack commented region fix typo in parse_args Bug fixes Minor pylint fix fix pylint issues rename function ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add logging-format-interpolation to list of pylint warnings we don't care about. That way, we can use python3 string formatting without getting warnings.
Test suite: code_checker
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1488
User interface changes?: None
Code review: @JEdwards