Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs in scripts_regression_tests.py test_cime_case_prereq for lsf batch system #2048

Closed
jedwards4b opened this issue Nov 10, 2017 · 1 comment
Closed

bugs in scripts_regression_tests.py test_cime_case_prereq for lsf batch system #2048

jedwards4b opened this issue Nov 10, 2017 · 1 comment
Assignees
@jgfouca
Labels
ty: Bug

Comments

@jedwards4b
Copy link
Contributor

config_batch.xml needs a field

  • <depend_separator>&&</depend_separator>

This would have been caught by config_batch.xsd but the schema is defined such that this is not a required field - it seems that scripts_regression_tests.py thinks it should be.

After fixing this I found that line 1463 of scripts_regression_tests.py

          dep_str = dep_str_fmt[:-len(jobid_ident)]

assumes that the dep_str format ends with the jobid, which is not the case for lsf systems, so dep_str gets set to -w 'done(jo which is incorrect.
@jedwards4b jedwards4b mentioned this issue Nov 15, 2017
Closed
@jgfouca
Copy link
Contributor

jgfouca commented Dec 13, 2017

Needed to support summit

@jgfouca jgfouca self-assigned this Dec 13, 2017
@jgfouca jgfouca mentioned this issue Jan 11, 2018
Merged
jedwards4b added a commit that referenced this issue Jan 11, 2018
@jedwards4b
Merge pull request #2224 from ESMCI/jgfouca/fix_cime_case_test_for_lsf
c3a1141 
Fix K_TestCimeCase.test_cime_case_prereq for LSF machines
Instead of assuming the jobid is the last part of the dep_str_fmt,
allow it to be somewhere in the middle or at the end.

Test suite: ./scripts_regression_tests.py K_TestCimeCase.test_cime_case_prereq (both LSF and SLURM)
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #2048

User interface changes?: N

Update gh-pages html (Y/N)?: N

Code review: @jedwards4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgfouca jgfouca

Labels
ty: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jedwards4b @jgfouca