Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce NaN checks for fields passed between components #1757

Closed
billsacks opened this issue Jul 25, 2017 · 0 comments
Closed

Introduce NaN checks for fields passed between components #1757

billsacks opened this issue Jul 25, 2017 · 0 comments
Assignees
@jedwards4b
Labels
tp: drv mct ty: enhancement
Milestone
CIMErelease

Comments

@billsacks
Copy link
Member

We want to introduce checks in the coupler that ensure that all fields passed from components are free of NaN values.

There is also value in having some other physical checks (like certain fields that should be non-negative), but feeling from a number of discussions is that those physical checks belong in components, not in the coupler.
@billsacks billsacks added this to the cesm2 milestone Jul 25, 2017
@jedwards4b jedwards4b mentioned this issue Jul 26, 2017
Merged
jgfouca added a commit that referenced this issue Jul 28, 2017
@jgfouca
Merge pull request #1765 from jedwards4b/check_flds_for_nan
9217c9b 
Check flds for nan

Checks incoming component fields for NaN in the coupler, fail on first NaN found, report
component name and instance, field name and 1d global index into field. Add a test in scripts_regression_tests.py that checks this feature is working.

Test suite: scripts_regression_tests.py , PFS.f19_g17.B1850.cheyenne_intel with and without to measure impact on performance (negligible)
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1757

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:
@ghost ghost removed the Assigned label Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards4b jedwards4b

Labels
tp: drv mct ty: enhancement
Projects
None yet
Milestone
CIMErelease
Development

No branches or pull requests
3 participants
@jedwards4b @billsacks @jgfouca