Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCN_NCPL logic doesn't handle CLM5 correctly #1687

Closed
billsacks opened this issue Jun 13, 2017 · 0 comments
Closed

OCN_NCPL logic doesn't handle CLM5 correctly #1687

billsacks opened this issue Jun 13, 2017 · 0 comments
Assignees
@billsacks
Labels
Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM tp: drv mct ty: Bug
Milestone
CIMErelease

Comments

@billsacks
Copy link
Member

src/drivers/mct/cime_config/config_component_cesm.xml has this (copied twice):

<value compset="_DATM.*_CLM4.*_SICE.*_SOCN">1</value>

This doesn't match CLM5. We should remove the 4 (and remove the duplicate line).
@billsacks billsacks added Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM tp: drv mct ty: Bug labels Jun 13, 2017
@billsacks billsacks added this to the cesm2 milestone Jun 13, 2017
@billsacks billsacks self-assigned this Jun 13, 2017
@billsacks billsacks mentioned this issue Jun 14, 2017
Merged
billsacks added a commit that referenced this issue Jul 6, 2017
@billsacks
Merge pull request #1688 from billsacks/ocn_ncpl_clm5
3d40552 
Apply OCN_NCPL setting to any version of CLM

Also remove a duplicate line

Test suite: Ran a few tests in a CLM sandbox: I compsets with clm45 and clm50
before and after this change. Verified that, with this change,
OCN_NCPL is 1 as desired for both clm45 and clm50.
Test baseline: N/A
Test namelist changes: Changes ocn_cpl_dt in drv_in for I compsets with clm50 
Test status: bit for bit
I haven't tested for bit-for-bit, but this change in the coupling frequency
of a stub model should not change answers

Fixes #1687 

User interface changes?: none

Code review: @mvertens
@ghost ghost removed the in progress label Jul 6, 2017
rljacob pushed a commit to E3SM-Project/E3SM that referenced this issue Apr 12, 2021
@billsacks
Merge pull request #1688 from billsacks/ocn_ncpl_clm5
8ce9e1d 
Apply OCN_NCPL setting to any version of CLM

Also remove a duplicate line

Test suite: Ran a few tests in a CLM sandbox: I compsets with clm45 and clm50
before and after this change. Verified that, with this change,
OCN_NCPL is 1 as desired for both clm45 and clm50.
Test baseline: N/A
Test namelist changes: Changes ocn_cpl_dt in drv_in for I compsets with clm50 
Test status: bit for bit
I haven't tested for bit-for-bit, but this change in the coupling frequency
of a stub model should not change answers

Fixes ESMCI/cime#1687 

User interface changes?: none

Code review: @mvertens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
Responsibility: CESM Responsibility to manage and accomplish this issue is through CESM tp: drv mct ty: Bug
Projects
None yet
Milestone
CIMErelease
Development

No branches or pull requests
1 participant
@billsacks