Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid attribute not checked when doing compset matches #1583

Closed
billsacks opened this issue May 21, 2017 · 4 comments
Closed

grid attribute not checked when doing compset matches #1583

billsacks opened this issue May 21, 2017 · 4 comments

Comments

@billsacks
Copy link
Member

config_compsets.xml files occasionally list a grid attribute on the compset line. An example from cime is:

  <compset grid="r%rx1">
    <alias>AIAF</alias>
    <lname>2000_DATM%IAF_SLND_DICE%IAF_DOCN%IAF_DROF%IAF_SGLC_SWAV</lname>
  </compset>

According to @mvertens (see discussion on #1582 ), this is supposed to stop you from creating a case with the given compset unless the grid matches the given expression. But this doesn't seem to be working. For example, cime master let me run the following without complaint:

./create_test --no-build --test-root . SMS.f19_g16_r01.AIAF.yellowstone_intel
  • where I'm using a rof grid that does not match 'r%rx1'.
@billsacks
Copy link
Member Author

(For the record, I don't view this as "critical", but @mvertens asked me to add that label.)

@jedwards4b
Copy link
Contributor

jedwards4b commented May 22, 2017

I think that trying to use the grid attribute in this file creates a circular reference situation in which the compset is needed to get the grid but the grid is needed to get the compset.

@jedwards4b jedwards4b self-assigned this May 22, 2017
@jedwards4b
Copy link
Contributor

The result of discussion - this is a circular dependency and the grid attribute should be removed from config_compsets.xml

@mvertens
Copy link
Contributor

@billsacks - I am assigning this to you since you had a clear idea of where compsets had a grid attribute.

jedwards4b added a commit that referenced this issue May 23, 2017
Remove grid attribute from compset elements.
This wasn't being checked, so wasn't serving any purpose

Test suite: none (the relevant compsets aren't covered by scripts_regression_tests anyway)
Test baseline: N/A
Test namelist changes: none
Test status: bit for bit

Fixes #1583

User interface changes?: none

Code review: Jedwards
@ghost ghost removed the in progress label May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants