-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grid attribute not checked when doing compset matches #1583
Comments
(For the record, I don't view this as "critical", but @mvertens asked me to add that label.) |
I think that trying to use the grid attribute in this file creates a circular reference situation in which the compset is needed to get the grid but the grid is needed to get the compset. |
The result of discussion - this is a circular dependency and the grid attribute should be removed from config_compsets.xml |
@billsacks - I am assigning this to you since you had a clear idea of where compsets had a grid attribute. |
Remove grid attribute from compset elements. This wasn't being checked, so wasn't serving any purpose Test suite: none (the relevant compsets aren't covered by scripts_regression_tests anyway) Test baseline: N/A Test namelist changes: none Test status: bit for bit Fixes #1583 User interface changes?: none Code review: Jedwards
config_compsets.xml files occasionally list a grid attribute on the compset line. An example from cime is:
According to @mvertens (see discussion on #1582 ), this is supposed to stop you from creating a case with the given compset unless the grid matches the given expression. But this doesn't seem to be working. For example, cime master let me run the following without complaint:
The text was updated successfully, but these errors were encountered: