Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update micm interface #89

Merged
merged 12 commits into from
Apr 15, 2024
Merged

Update micm interface #89

merged 12 commits into from
Apr 15, 2024

Conversation

K20shores
Copy link
Collaborator

@K20shores K20shores commented Mar 23, 2024

Uses a newer micm interface

closes NCAR/musica#72

@K20shores K20shores requested a review from boulderdaze March 26, 2024 16:19
Copy link
Collaborator

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one ChangeLog text change request (but I don't need to re-review).

doc/ChangeLog Outdated
Comment on lines 21 to 22
See [https://github.com/ESCOMP/atmospheric_physics/pull/89](https://github.com/ESCOMP/atmospheric_physics/pull/89)
for a list of changed files and what changed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace this with the following:

M       .github/workflows/test.yaml
          - Clean-up Github Action workflow
         
M       musica/micm/micm.F90
M       test/CMakeLists.txt
M       test/docker/Dockerfile.musica
M       test/musica/micm/CMakeLists.txt
           - Update MICM interface

Feel free to change the wording too if I didn't capture the changes correctly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mattldawson mattldawson merged commit 98cd47b into main Apr 15, 2024
1 check passed
@mattldawson mattldawson deleted the update_micm_interface branch April 15, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update atmospheric physics usage of the musica wrapper's new api
5 participants