-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update micm interface #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one ChangeLog
text change request (but I don't need to re-review).
doc/ChangeLog
Outdated
See [https://github.com/ESCOMP/atmospheric_physics/pull/89](https://github.com/ESCOMP/atmospheric_physics/pull/89) | ||
for a list of changed files and what changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace this with the following:
M .github/workflows/test.yaml
- Clean-up Github Action workflow
M musica/micm/micm.F90
M test/CMakeLists.txt
M test/docker/Dockerfile.musica
M test/musica/micm/CMakeLists.txt
- Update MICM interface
Feel free to change the wording too if I didn't capture the changes correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Uses a newer micm interface
closes NCAR/musica#72