-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MICM wrapper for species unit conversions #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boulderdaze Looks good! Just have some hopefully minor change requests.
Also I am happy to leave the final decision up to you, @mattldawson, and others, but I personally think we could incorporate the Github Action test you made in your fork into this repo. I did request some changes that might require modifying the test itself, and its unclear what our final testing framework will look like, but all else being equal I would rather get some test coverage in now then wait for a "perfect" system later. If you all agree then we can either add the test and Github action to this PR now or add it as a separate PR later (either way is fine with me). Thanks!
musica/micm/micm.F90
Outdated
! TODO(jiwon) Checks the denominator is non zero | ||
! this code needs to go when ccpp framework does the check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be pretty easy to do this check in the constituents object itself during instantiation, or during the "set" call, as having a molar mass of zero is unphysical. What do you think @peverwhee? If so then maybe we can get this done sooner rather than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new testing infrastructure @boulderdaze! I did have some more questions and suggestions, but hopefully nothing that causes any major difficulties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I think having these tests started is going to be very helpful moving forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me now, thanks again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jiwon! A couple of small comments, but nothing that should hold up the PR.
Closes #73
mol m-3
->kg kg-1
and vise versa