Add constituent tendency updater #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
requested changes
Nov 8, 2024
nusbaume
approved these changes
Nov 9, 2024
mwaxmonsky
approved these changes
Nov 11, 2024
peverwhee
added a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Nov 27, 2024
Tag name (required for main): Originator(s): peverwhee Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): Brings in and enables new apply_constituent_tendencies scheme (from ESCOMP/atmospheric_physics#111) Describe any changes made to build system: Exclude constituent tendencies from required variables (now handled by the CCPP Framework in NCAR/ccpp-framework#584) Describe any changes made to the namelist: None List any changes to the defaults for the input datasets (e.g. boundary datasets): None List all files eliminated and why: None List all files added and what they do: None List all existing files that have been modified, and describe the changes: (Helpful git command: `git diff --name-status development...<your_branch_name>`) M .gitmodules - update CCPP-Framework and atmospheric_physics externals to point to updates for constituent tendencies M src/data/write_init_files.py - exclude constituent tendency variables (and array) from required variables list If there are new failures (compare to the existing-test-failures.txt file), have them OK'd by the gatekeeper, note them here, and add them to the file. If there are baseline differences, include the test and the reason for the diff. What is the nature of the change? Roundoff? derecho/intel/aux_sima: derecho/gnu/aux_sima: CAM-SIMA date used for the baseline comparison tests if different than latest: --------- Co-authored-by: Courtney Peverley <courtneyp@izumi.cgd.ucar.edu>
jimmielin
added a commit
that referenced
this pull request
Dec 31, 2024
Tag name (The PR title should also include the tag name): `atmos_phys0_07_001` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * Update extraterrestrial flux in TUV-x prior to calculating rate constants #152 by @boulderdaze * Simplify deallocation of multiple objects associated with the TUV-x #156 by @boulderdaze * Fill in errmsg, errflg in check_energy schemes #160 by @jimmielin * Validates the MUSICA meta data against the CCPP standard names #162 by @boulderdaze * Add constituent tendency updater #111 by @peverwhee * Add cloud optical calculations for use in TUV-x #167 by @mattldawson * Add initialize_constituents scheme #149 by @peverwhee * Add diagnostics to TJ2016 test schemes #170 by @peverwhee * update "radians" to "rad" #173 by @peverwhee * Solar zenith angle and Earth-Sun distance #171 by @mattldawson * Update standard names for tropopause_find #140 by @jimmielin * Update surface albedo units #181 by @mattldawson * don't set water species property for species that air_composition handles #185 by @peverwhee List all test failures: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): peverwhee
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Adds the
apply_constituent_tendenciesscheme toutilties/physics_tendency_updaters.F90.Describe any changes made to the namelist: None
List all files eliminated and why:
D schemes/dry_adiabatic_adjust/dadadj_apply_qv_tendency.F90
D schemes/dry_adiabatic_adjust/dadadj_apply_qv_tendency.meta
List all files added and what they do: none
List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M schemes/dry_adiabatic_adjust/dadadj.meta
constituent = Truemetadata property to tendency variableM schemes/utilities/physics_tendency_updaters.F90
M schemes/utilities/physics_tendency_updaters.meta
apply_constituent_tendenciesschemeM test/test_suites/suite_dry_adiabatic_adjust.xml
List any test failures: none
Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No