Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct bugfix in Metadata-standard-names.md #1

Conversation

climbfuji
Copy link
Collaborator

Correct bugfix in Metadata-standard-names.md (replace _loop_extent with _dimension)

Correct bugfix in Metadata-standard-names.md (replace _loop_extent with _dimension)
@gold2718
Copy link
Collaborator

gold2718 commented Mar 12, 2020

Two comments:

  1. This is not a bug, it happens when the host model metadata has horizontal_dimension but the scheme has horizontal_loop_extent (i.e., all the time for xx_run routines).
  2. The markdown file is generated from the XML file, please edit the XML and follow the instructions in README.md to regenerate the markdown.

@gold2718 gold2718 closed this Mar 12, 2020
@climbfuji
Copy link
Collaborator Author

So shouldn't the host model provide both? Or are we ok with having only horizontal_dimension and use it for the _run routines when horizontal_loop_extend does not exist?

@gold2718
Copy link
Collaborator

The metadata for a host model field (say temperature) has one entry. That entry uses horizontal_dimension because that is the size of the data on the host model.
At run time, the host model will either pass the entire array, or will pass part of it in a loop (which may be threaded). In either case, the schemes interpret whatever the host model is sending as horizontal_loop_extent. That is why capgen can make that substitution during the analysis of xx_run scheme interfaces.

@climbfuji
Copy link
Collaborator Author

Got it, thanks for the explanation.

grantfirl pushed a commit to grantfirl/CCPPStandardNames that referenced this pull request Jun 23, 2021
remove duplication in UFS-based XML additions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants