ctsm5.3.018: Change history time to be equal to the middle of the time bounds #2838
Task list completed / task-list-completed
succeeded
Jan 11, 2025 in 0s
7 / 7 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
| Update to ctsm5.3.012 | Completed |
| Update .gitmodules | Completed |
| mosart/rtm test suites | Completed |
| Run aux_clm | Completed |
| Merge and make tag | Incomplete |
| these two are the only long tests with active cism | Incomplete |
| the changes appear in the coupler due to the changes in mosart and not due to changes in ctsm | Incomplete |
| that he would not expect these diffs (as I also didn't), so he would recommend going through a methodical way of testing, making baselines, and updating the code and the baselines to confirm whether I still get these diffs | Incomplete |
| I must still make the same change to the corresponding rtm/mosart file. Move this TODO to the third "history" tag because that one still has mosart/rtm PRs that I have not merged. | Completed |
| If you're up for approving this one, then I would be ready to move forward with the merge when it's time. | Incomplete |
| You have seen it before; it should look very familiar, other than an addition from Sam Rabin pertaining to cropcal_module.py. | Incomplete |
| The first command confirms that all FAILs are baseline diffs, as expected: | |
| This test fails, and Sam Rabin's fix is coming in with one of the next two "history" tags: | |
FAIL RXCROPMATURITYSKIPGEN_Ld1097.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput RUN |
Incomplete |
| The second line confirms that all baseline diffs are in the time variable, as expected: | Incomplete |
| The mosart/cpl diffs are explained here: #2838 (comment) | |
| and will be resolved by replacing the if-statement in commit 692d183 with a comment, as explained in this comment.. Move this TODO to the third "history" tag because that one still has mosart/rtm PRs that I have not merged. | Completed |
| ERS_D_Ld20.f45_f45_mg37.I2000Clm50FatesRs.derecho_intel.clm-FatesColdTwoStream has diffs that I can't explain: | Completed |
| param and fates_param files are the same, but could this explain the diffs? | Incomplete |
| I repeated the test with ./create_test twice; once from ctsm5.3.017 and once from this branch. Both behaved as expected with the former b4b and the latter giving DIFFs in the time variable only. I regenerated the baseline for this test and will treat the previous result as unexplained. | Incomplete |
Loading