Neon updates #1872
Merged
Neon updates #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework fates test definitions and add new fates tests This tag includes a number of updates to the fates test definitions and test list to gain more coverage: (1) Reorder and update the fates test definitions so that fates satellite phenology mode can be configured for cases using a compset. (2) Add a long-term exact restart test to catch issues that may arise due to updates to fates procedure calls during end of year simulation dates. (3) Add a no-competition + fixed biogeography, non-satellite phenology test definition to provide additional mode combination configuration. (4) Update the fates externals tag to incorporate a fix a vegetation temperature exact restart issue discovered while implementing (1) above. (5) Truncate all testmods starting with "Fates" to mitigate running over the limits on the length of testnames, typically when specifying custom `test_id` using `run_sys_test`. (6) Updates the expected failures list.
|
I copied files to inputdata directory "$DIN_LOC_ROOT/lnd/clm2/surfdata_map/NEON/" and added them to the inputdata repo. |
|
@ekluzek when you make a new lightening mesh file for the cropped NEON region we can also change the following in /usermods_dirs/NEON/defaults/shell_commands Let's also notify @briandobbins when this PR comes in. |
|
Awesome suggestions! Let’s find a time to discuss this soon. Thanks Erik.
|
Correct path for initial conditions
removed unused code, per @ekluzek 's suggestion
Closed
…ds are going will be written out fixing ESCOMP#1896
…t the inputdata_path directory exists if provided
…a unit test for it
…t exist aborts as expected
…rate path and can work on izumi as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Minor changes to python scripts and usermod_dirs for NEON cases. Also update the lightning mesh file so that it goes with the smaller lightning file. Have NEON use new use-cases for 2018 and 2018-PD conditions for CLM. Have NEON
Agricultural sites run with prognostic crop. Simple fix for warning about NaN's in import/export data from/to coupler.
Make sure tools testing is working, and make some changes so NEON tests work on both cheyenne and izumi.
Also update MOSART with fixed for direct_to_outlet option.
Specific notes
fixes #1871
fixes #1876
fixes #1889
fixes #1363
fixes #1896
fixes #1901
Generated all new NEON surface datasets for completeness.
Generating new initial conditions files and transient simulations for STER and KONA tests.
Checked that other sites ran as expected.
Test suite results are as expected on cheyenne and izumi