Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWT_SLASH_CFLUX is calculated on the column, but really should be a patch level quantity #787

Closed
ekluzek opened this issue Aug 15, 2019 · 0 comments · Fixed by #802
Closed
Assignees
Labels
bug something is working incorrectly

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 15, 2019

Brief summary of bug

The history field DWT_SLASH_CFLUX is being calculated on the column, but it's inherently a patch level quantity should be calculated on the patch level and then you can average up to column, land-unit or grid-cell.

General bug information

CTSM version you are using: ctsm1.0.dev055

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected:

Example of cases where this comes into play are the following tests:

FAIL ERP_P36x2_Lm13.f10_f10_musgs.IHistClm50Bgc.cheyenne_gnu.clm-monthly BASELINE ctsm1.0.dev055: DIFF
FAIL ERP_P36x2_Lm13.f10_f10_musgs.IHistClm50Bgc.cheyenne_intel.clm-monthly BASELINE ctsm1.0.dev055: DIFF
FAIL ERP_P36x2_Lm25.f10_f10_musgs.I2000Clm50BgcDvCrop.cheyenne_intel.clm-monthly BASELINE ctsm1.0.dev055: DIFF
FAIL ERP_P72x2_Lm25.f10_f10_musgs.I2000Clm50BgcDvCrop.cheyenne_intel.clm-monthly BASELINE ctsm1.0.dev055: DIFF
FAIL LCISO_Lm13.f10_f10_musgs.IHistClm50BgcCrop.cheyenne_intel.clm-ciso_monthly BASELINE ctsm1.0.dev055: DIFF
FAIL SMS_Lm1.f10_f10_musgs.I1850Clm50BgcCropCmip6waccm.cheyenne_gnu.clm-basic BASELINE ctsm1.0.dev055: DIFF

@ekluzek ekluzek self-assigned this Aug 15, 2019
@billsacks billsacks added bug something is working incorrectly and removed tag: bug - impacts science labels Aug 16, 2019
ekluzek added a commit to ekluzek/CTSM that referenced this issue Aug 28, 2019
ekluzek added a commit to ekluzek/CTSM that referenced this issue Aug 28, 2019
ekluzek added a commit to ekluzek/CTSM that referenced this issue Aug 29, 2019
This reverts commit f2869fe.
This is the DWT_SLASH issue.
ekluzek added a commit to ekluzek/CTSM that referenced this issue Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants