Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment fates_levleaf fields #1561

Closed
ekluzek opened this issue Nov 24, 2021 · 2 comments · Fixed by #1562
Closed

Uncomment fates_levleaf fields #1561

ekluzek opened this issue Nov 24, 2021 · 2 comments · Fixed by #1562
Assignees
@ekluzek
Labels
bug something is working incorrectly

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Nov 24, 2021

In ctsm5.1.dev062 I brought in PR #1540, but in order to not have to include a new FATES tag I commented out two lines for the fates_levleaf dimension in this commit...

5e1adf8

We didn't want to bring in a new FATES tag since we didn't have one that just did that one change. And we needed answers for FATES to be identical, since we were already bringing in answer changes going to NUOPC as the new driver.

@glemieux @rgknox let me know if you have any feedback on this. @adrifoster
@ekluzek ekluzek added the bug something is working incorrectly label Nov 24, 2021
@ekluzek ekluzek self-assigned this Nov 24, 2021
ekluzek added a commit to ekluzek/CTSM that referenced this issue Nov 24, 2021
@ekluzek
Revert "Comment out fates_hdim_levleaf so that don't need a new fates…
6e8ce48 
… version"

This reverts commit 5e1adf8.

And hence fixed ESCOMP#1561 by uncommenting fates_levleaf dimension.
@ekluzek ekluzek mentioned this issue Nov 24, 2021
Merged
@adrifoster adrifoster mentioned this issue Nov 24, 2021
Merged
@glemieux
Copy link
Collaborator

I think we can leave this commented out as is; the fates-side change that will utilize this will be NGEET/fates#752, but @ckoven wanted to re-evaluate this PR after we've integrated @adrifoster's #1542. So for now the DIFFs on the fates_levleaf dimension output will be junk, which is as expected until we hook it up on the fates side.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 24, 2021

Some of the discussion on this is here in PR #1540...

My finding of the problem...

#1540 (comment)

@glemieux response...

#1540 (comment)

And my comments about what I did..

#1540 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
bug something is working incorrectly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Uncomment fates_hdim_levleaf dimension ekluzek/CTSM
2 participants
@glemieux @ekluzek