initial port to CESM+NUOPC #1
Conversation
|
I just pushed another set of changes that addresses the ice_ic problem. It now works with the out of the box initial conditions for the test I ran. There was an error in setting nslyr in the namelist. I also started some of the cleanup of the buildlib and buildcpp scripts. I am goint to continue that effort, although I expect to get stuck at some point and may need help. |
| " -DNBGCLYR=%s -DNICELYR=%s -DNSNWLYR=%s" \ | ||
| " -DTRAGE=%s -DTRFY=%s -DTRLVL=%s -DTRPND=%s -DTRBRI=%s -DTRBGCS=%s" \ | ||
| %(ncat,nx,ny,ntr_aero,ntr_iso,nbgclyr,nicelyr,nsnwlyr,trage,trfy,trlvl,trpnd,trbri,trbgcs) | ||
| # tcraig, moved to namelist_definition_cice.xml |
There was a problem hiding this comment.
If the following are namelist settings - this logic should be moved to buildnml - and removed from buildcpp. Please remove the commented out code - since its clear from the PR code what has been removed - and this will make buildcpp much easier to understand.
There was a problem hiding this comment.
As I noted above, I continue to work on the cleanup. I'm committing things as I make progress. I think we all recognize there is still work to do.
There was a problem hiding this comment.
Sounds fine. I committing my changes to my branch as you suggested. I created PRs as you suggested. I think it's great that others are looking at what changes are coming in as I make progress. I encourage others to provide feedback, I don't really have a good handle on all aspects of these scripts. There is still work to do before this is done, and it might not "all" get done just in this PR. We can merge the PR whenever folks want.
|
@apcraig - please me know when you are ready for the PR to be evaluated. I
am happy to do that and not make comments until then.
…On Thu, Oct 24, 2019 at 11:32 AM Tony Craig ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In cime_config/buildcpp
<#1 (comment)>:
> - ncat = 5
- ncat = set_nondefault_cpp(cice_config_opts, "ncat", ncat)
- case.set_value("ICE_NCAT",ncat)
- logger.debug("cice: number of ice categories (ncat) is %s" %ncat)
-
- # set decomposition block sizes
- cice_blckx = case.get_value("CICE_BLCKX")
- cice_blcky = case.get_value("CICE_BLCKY")
- cice_mxblcks = case.get_value("CICE_MXBLCKS")
-
- cice_cppdefs = " -DCESMCOUPLED -Dncdf -DNUMIN=11 -DNUMAX=99 " \
- " -DNICECAT=%s -DNXGLOB=%s -DNYGLOB=%s -DNTRAERO=%s -DNTRISO=%s" \
- " -DNBGCLYR=%s -DNICELYR=%s -DNSNWLYR=%s" \
- " -DTRAGE=%s -DTRFY=%s -DTRLVL=%s -DTRPND=%s -DTRBRI=%s -DTRBGCS=%s" \
- %(ncat,nx,ny,ntr_aero,ntr_iso,nbgclyr,nicelyr,nsnwlyr,trage,trfy,trlvl,trpnd,trbri,trbgcs)
+# tcraig, moved to namelist_definition_cice.xml
As I noted above, I continue to work on the cleanup. I'm committing things
as I make progress. I think we all recognize there is still work to do.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1?email_source=notifications&email_token=AB4XCE4O7OQKK44GFCTXYITQQHL3FA5CNFSM4JEMLYJ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJEJAJA#discussion_r338701283>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XCE2ME72QNOHZWBFFEHLQQHL3FANCNFSM4JEMLYJQ>
.
|
* modifying PR template * updating PR template * adding link to documentation for PR (ESCOMP#1) * modifying PR template * typo * modifying wording * modifying link per PBsuggestion * adding second link * adding Tony's changes * typo * Making ECH suggestions
Dev/cmcc cm3 Update of CICE6 based on cesm2.3_alpha10c tag in CMCC-CM3
addition of blom grid
Initial port of CICE6 into CESM+NUOPC.
See also ESCOMP/CICE#1