This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosolidkk
reviewed
May 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugs
- Ao se apagar uma conversa, ocorre um warning referente a um documento não encontrado. Ele aparece diversas vezes podendo ocasionar crash no app.
- Ao se entrar em uma conversa que possui mensagens não lidas e voltar para tela de conversas, se o usuário recebe uma nova mensagem, o contador de mensagens não lidas não aparece.
- Vez ou outra pode ocorrer um erro com uma função toDate(), não sei a causa exata e os passos pra reprodução, porém o warning do item número 1 pode ocasionar esse error.
netochaves
reviewed
May 14, 2019
netochaves
reviewed
May 14, 2019
netochaves
reviewed
May 14, 2019
sosolidkk
approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testada por @netochaves @sosolidkk .
Aprovada por @sosolidkk @netochaves .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues que foram resolvidas: #99 e #116
O que foi feito