[ScfToCf] Signedness-aware scf::ForOp
lowering
#38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new conversion pass to Dynamatic++ (--lower-scf-to-cf) that is almost identical to the upstream
--convert-scf-to-cf
pass, which, as its name indicates, convertsscf
operations to unstructured control flow (cf
). The only difference between the two is that thescf::ForOp
rewrite pattern used in our pass (which overwrites the default one) inserts an unsigned comparison operation for checking whether the loop iterator is within the for loop's bounds instead of a signed one if it can prove that both the iterator and upper bound are guaranteed to be positive. The estimation relies on the recently introduced numerical analysis. This has a performance impact down-the-line during bitwidth analysis.Fixes #28.