Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[handshake-sim] Added JSON configuration for execution model #11

Merged
merged 9 commits into from
Jul 28, 2023

Conversation

Polymeth
Copy link
Collaborator

Added JSON configuration file to select execution models
Added --change-model command to modify execution models configuration and JSON

Copy link
Member

@lucas-rami lucas-rami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good but some things to address. I actually had no idea that LLVM had JSON parsing support, this is great. Aside from what I wrote please use clang-format/clang-tidy on the code. I opened handshake-simulator.cpp in my IDE and there are some code warnings + formatting issues.

Copy link
Member

@lucas-rami lucas-rami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very cosmetic things to change, but all good otherwise, thanks!

One important thing though, the PR includes a CIRCT change that should not be there (you can see it on the "Files changed" tab of the PR). To fix pull all changes (including from submodules), cd to the circt folder, checkout the HEAD of main there, go back to the top-level dynamatic folder, and git add circt (then commit and push). It should fix the issue.

@lucas-rami lucas-rami force-pushed the handshake-simulator22 branch from 34fc059 to 245d9e2 Compare July 28, 2023 16:23
@lucas-rami
Copy link
Member

I went to fix the CIRCT commit myself, it was kinda a mess but hey, it works.

@lucas-rami lucas-rami merged commit 27e7040 into main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants