This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add trace plugin API test #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjohnson5972
suggested changes
Jun 16, 2020
brianjohnson5972
approved these changes
Jun 16, 2020
tests/trace_plugin_test.py
Outdated
|
|
||
| @classmethod | ||
| def tearDownClass(self): | ||
| self.cleanEnv(self) |
There was a problem hiding this comment.
either need to check if test passed or just don't call cleanup() when tearing down
tests/trace_plugin_test.py
Outdated
|
|
||
| self.assertEqual(node.getAccountEosBalanceStr(self.accounts[0].name), Utils.deduceAmount(expectedAmount, xferAmount)) | ||
| self.assertEqual(node.getAccountEosBalanceStr(self.accounts[1].name), Utils.addAmount(expectedAmount, xferAmount)) | ||
| ret_json = self.get_block(blockNum, node) |
There was a problem hiding this comment.
before this, call node.getBlock(blockNum) to retrieve the block and verify that you can find the transaction id in the block, this way if this test case ever fails, we will know whether the problem is in trace_api or before it.
brianjohnson5972
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Testing:
Jira: https://blockone.atlassian.net/browse/EPE-104
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions